Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLRenderer: Add missing parameters to copyTextureToTexture #28663

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

gkjohnson
Copy link
Collaborator

Related issue: #28281

Description

Add missing "width" and "height" arguments to texSubImage2D function in the copyTextureToTexture function. It looks like this was missing before #28281 but it looks like an oversight. These arguments aren't missing in the 3d variant of the function.

This contribution is funded by Cesium GIS Ecosystem Grant

@gkjohnson gkjohnson added this to the r166 milestone Jun 15, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
679.4 kB (168.3 kB) 679.4 kB (168.3 kB) +4 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
457.4 kB (110.4 kB) 457.4 kB (110.4 kB) +4 B

@gkjohnson gkjohnson merged commit 9e5244f into mrdoob:dev Jun 15, 2024
12 checks passed
@gkjohnson gkjohnson deleted the copy-texture-fix branch June 15, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants