Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodes: Fix WGSL Vertex Code Directive Typo #29023

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Nodes: Fix WGSL Vertex Code Directive Typo #29023

merged 1 commit into from
Jul 30, 2024

Conversation

cmhhelgeson
Copy link
Contributor

Description

Remove dangling semicolon from _getWGSLVertexCode() when no directives are defined.

@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
684 kB (169.4 kB) 684 kB (169.4 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
460.9 kB (111.2 kB) 460.9 kB (111.2 kB) +0 B

@sunag sunag added this to the r168 milestone Jul 30, 2024
@sunag sunag merged commit 4118e2b into mrdoob:dev Jul 30, 2024
12 checks passed
@cmhhelgeson cmhhelgeson deleted the wgsl_directive_typo branch August 5, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r168
Development

Successfully merging this pull request may close these issues.
2 participants
@cmhhelgeson @sunag