Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSL: Add workingToColorSpace, colorSpaceToWorking #29378

Merged
merged 6 commits into from
Sep 12, 2024
Merged

TSL: Add workingToColorSpace, colorSpaceToWorking #29378

merged 6 commits into from
Sep 12, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Sep 10, 2024

Based on this conversation: #29259 (comment)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 685.42
169.7		 685.42
169.7		 +0 B
+0 B
WebGPU 828.13
222.15		 828.45
222.25		 +318 B
+106 B
WebGPU Nodes 827.71
222.05		 828.03
222.16		 +318 B
+106 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.02
111.48		 462.02
111.48		 +0 B
+0 B
WebGPU 526.16
141.85		 526.43
141.9		 +265 B
+58 B
WebGPU Nodes 482.82
131.66		 483.08
131.72		 +265 B
+62 B

@sunag sunag added this to the r169 milestone Sep 12, 2024
@sunag sunag marked this pull request as ready for review September 12, 2024 04:53
@sunag sunag merged commit ee17dec into mrdoob:dev Sep 12, 2024
12 checks passed
@sunag sunag deleted the dev-colorspace-rev branch September 12, 2024 05:33
LD2Studio pushed a commit to LD2Studio/LD2Studio-Editor that referenced this pull request Sep 13, 2024
@sunag @LD2Studio
TSL: Add workingToColorSpace, colorSpaceToWorking (mrdoob#29378)
c3da9cc 
* add `workingToColorSpace`, `colorSpaceToWorking`

* Update TextureNode.js

* Update RenderOutputNode.js

* Update RenderOutputNode.js

* update

* Update ColorSpaceNode.js
LD2Studio pushed a commit to LD2Studio/LD2Studio-Editor that referenced this pull request Sep 13, 2024
@sunag @LD2Studio
TSL: Add workingToColorSpace, colorSpaceToWorking (mrdoob#29378)
ce96f62 
* add `workingToColorSpace`, `colorSpaceToWorking`

* Update TextureNode.js

* Update RenderOutputNode.js

* Update RenderOutputNode.js

* update

* Update ColorSpaceNode.js
This was referenced Sep 24, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WestLangley WestLangley WestLangley left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r169
Development

Successfully merging this pull request may close these issues.
2 participants
@sunag @WestLangley