Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpriteMaterial: Simplify shader. #29397

Merged
merged 1 commit into from
Sep 17, 2024
Merged

SpriteMaterial: Simplify shader. #29397

merged 1 commit into from
Sep 17, 2024

Conversation

WestLangley
Copy link
Collaborator

As the title says.

@WestLangley WestLangley added this to the r169 milestone Sep 12, 2024
@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 685.83
169.75		 685.69
169.74		 -133 B
-12 B
WebGPU 828.45
222.25		 828.45
222.25		 +0 B
+0 B
WebGPU Nodes 828.03
222.16		 828.03
222.16		 +0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.42
111.53		 462.29
111.52		 -133 B
-14 B
WebGPU 526.43
141.9		 526.43
141.9		 +0 B
+0 B
WebGPU Nodes 483.08
131.72		 483.08
131.72		 +0 B
+0 B

@Mugen87 Mugen87 changed the title Src: simplify Sprite shader SpriteMaterial: Simplify shader. Sep 17, 2024
@Mugen87 Mugen87 merged commit 2208e81 into mrdoob:dev Sep 17, 2024
12 checks passed
@WestLangley WestLangley deleted the dev-sprite_shader branch September 17, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r169
Development

Successfully merging this pull request may close these issues.
2 participants
@WestLangley @Mugen87