-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Codesandbox has missing files #9474
Comments
@mbrookes @oliviertassinari Is ok if I do some work on this issue? |
We use an import to avoid code duplication between the demos. It was done on purpose. I don't think that the issue should change the tradeoff. The best option I can think of is to disable the codesandbox link for those demos. |
@oliviertassinari Sorry, I should have been more clear. I wasn't talking about modifying the demos. I thought there would be some way to include external files when creating the sandbox, so i meant that i would work on that. |
@oliviertassinari Would something like this be possibility? If not, i can take care of removing the sandbox links on these pages for now. |
@lukePeavey Thanks for giving a shot at the issue and exploring it! I still think that the simplest option is to disable the codesandbox like by adding some explicit params in the |
Ok, that makes sense. |
Now fixed. |
Ok, #9521 is setting up the infrastructure needed for hiding the codesandox button on the conflicting demos. |
Could i take care of adding this option to the rest of demos (Drawer + GridList)? |
@lukePeavey It would be awesome. I'm not sure which demos need it. |
@lukePeavey Raised an interesting point. We have some weird HTTP 414 in:
|
I don't understand. This PR #9491 was lost along the way. We need to apply it back! Then we can close this issue 🎉 . |
One more thing before you close this... This might be a separate issue, but |
Would it work to replace relative urls to |
Oh, it's something you added in a previous PR. Yeah. It's a simple fix :). |
Ok, cool |
We have done quite some iteration on this issue. We should be in a good shape now. I think that it would be good in the future to add a link toward a different online editor. @lukePeavey I haven't ported your image replacement logic. I couldn't find it. Feel free to submit a pull-request to add it in the future :). Closes mui#9474
We have done quite some iteration on this issue. We should be in a good shape now. I think that it would be good in the future to add a link toward a different online editor. @lukePeavey I haven't ported your image replacement logic. I couldn't find it. Feel free to submit a pull-request to add it in the future :). Closes #9474
Hello,
It's great to have code sandbox in docs. It'll save me a lot of time while prototyping.
I realized that, drawers(completely) and components with images are not working properly.
Avatar;
Drawer;
https://material-ui.com/demos/drawers/
https://codesandbox.io/s/zpro6nj7m
Gridlist;
https://codesandbox.io/s/r4mk39vkxq
etc.
Thank you for your effort.
The text was updated successfully, but these errors were encountered: