[docs] Set the infrastructure for a full page demo #13314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
oliviertassinari
force-pushed
the
docs-infrastructure-full-page-demos
branch
6 times, most recently
from
550bd49
to
e12e014
Compare
|
This one seems to be coming up blank for me: https://deploy-preview-13314--material-ui.netlify.com/demos/app-bar/#bottom-app-bar |
|
@mbrookes It's still wip. Thanks for reporting that major issue 😱. |
oliviertassinari
force-pushed
the
docs-infrastructure-full-page-demos
branch
from
e12e014
to
cac39a1
Compare
|
back to 100% test coverage. I have introduced a regression earlier without noticing it. |
kof
reviewed
Oct 21, 2018
| <main className={classes.content}> | ||
| <div className={classes.toolbar} /> | ||
| <Typography paragraph> | ||
| Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt |
There was a problem hiding this comment.
recently discovered there is a package for generating texts like this: https://www.npmjs.com/package/lorem-ipsum
There was a problem hiding this comment.
We could have used a dependency, but here, I'm optimizing for copy & paste. Users might not have lorem-ipsum installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's rendering the demos in an iframe. This way, we can write code that matches people needs. They can directly copy & paste the demo in their app 🦈 .
Closes #11179.
Closes #13304.