Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Open the Docs-infra engineer role #42101

Merged
merged 23 commits into from
Jun 2, 2024

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented May 3, 2024

I'll comment on some specific sections that may be worth debating right away!
https://deploy-preview-42101--material-ui.netlify.app/careers/react-engineer-docs-infra/

@danilo-leal danilo-leal added website Pages that are not documentation-related, marketing-focused. scope: docs-infra Specific to the docs-infra product labels May 3, 2024
@danilo-leal danilo-leal requested review from oliviertassinari and a team May 3, 2024 00:47
@mui-bot
Copy link

mui-bot commented May 3, 2024

Netlify deploy preview

https://deploy-preview-42101--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 08becf1

@danilo-leal danilo-leal self-assigned this May 3, 2024
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look deep, but on the surface it looks good

docs/pages/careers/react-engineer-docs-infra.md Outdated Show resolved Hide resolved

## How to apply

[Apply now for this position 📮](/careers/react-engineer-docs-infra/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Apply now for this position 📮](/careers/react-engineer-docs-infra/)
[Apply now for this position 📮](TODO)

Copy link
Member

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tangential to this PR but something to consider: should this role be part of the DevEx team? I know the current plan is for this person to report to @danilo-leal , but I think there's a strong case to be made that (sooner or later) they should report to Head of DevEx (once such a role exists). Namely that the the docs UX is more or less synonymous with DX; there would be lots of opportunities to gather and iterate on user feedback; and it requires this person to collaborate with all of the eng teams as well as content-focused DevEx roles. But maybe this is a conversation better suited for Notion.

docs/pages/careers.tsx Outdated Show resolved Hide resolved
docs/pages/careers/react-engineer-docs-infra.md Outdated Show resolved Hide resolved
docs/pages/careers/react-engineer-docs-infra.md Outdated Show resolved Hide resolved
docs/pages/careers/react-engineer-docs-infra.md Outdated Show resolved Hide resolved
docs/pages/careers/react-engineer-docs-infra.md Outdated Show resolved Hide resolved
docs/pages/careers/react-engineer-docs-infra.md Outdated Show resolved Hide resolved
docs/pages/careers/react-engineer-docs-infra.md Outdated Show resolved Hide resolved
docs/pages/careers/react-engineer-docs-infra.md Outdated Show resolved Hide resolved
docs/pages/careers/react-engineer-docs-infra.md Outdated Show resolved Hide resolved
@danilo-leal
Copy link
Contributor Author

@samuelsycamore — yeah, let's pick up this discussion somewhere in Notion! Overall, I think it makes sense, and it also speaks to how cross-discipline DevEx also with design.

@oliviertassinari oliviertassinari added the needs cherry-pick The PR should be cherry-picked to master after merge label Jun 2, 2024
@oliviertassinari
Copy link
Member

Rebased on next

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a few changes, very cool, excited about this role!

cc @alexfauquette for context, this role is going live.

@oliviertassinari oliviertassinari enabled auto-merge (squash) June 2, 2024 14:23
@oliviertassinari oliviertassinari changed the title [website] Open the docs-infra engineer role [website] Open the Docs-infra engineer role Jun 2, 2024
@oliviertassinari oliviertassinari merged commit e4a33e7 into mui:next Jun 2, 2024
21 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 2, 2024
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs cherry-pick The PR should be cherry-picked to master after merge scope: docs-infra Specific to the docs-infra product website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants