-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Fix cell value formatting on copy #12357
Conversation
Deploy preview: https://deploy-preview-12357--material-ui-x.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Co-authored-by: Andrew Cherniavskyi <andrew@mui.com>
/** | ||
* @ignore | ||
* If `false`, the quotes will not be appended to the cell value. | ||
* @default true | ||
*/ | ||
shouldAppendQuotes?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of the property feels a bit weird to me. What's the purpose of should
here? It feels like this would work as well.
/** | |
* @ignore | |
* If `false`, the quotes will not be appended to the cell value. | |
* @default true | |
*/ | |
shouldAppendQuotes?: boolean; | |
/** | |
* @ignore | |
* If `false`, the quotes will not be appended to the cell value. | |
* @default true | |
*/ | |
appendQuotes?: boolean; |
Co-authored-by: Andrew Cherniavskyi <andrew@mui.com>
closes: #11945
proof: https://www.loom.com/share/1172637d62604d888679c90236c0e586
preview: https://deploy-preview-12357--material-ui-x.netlify.app/x/react-data-grid/recipes-editing/