Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[l10n] Add Icelandic (is-IS) locale #13283

Merged
merged 4 commits into from
Jul 24, 2024
Merged

[l10n] Add Icelandic (is-IS) locale #13283

merged 4 commits into from
Jul 24, 2024

Conversation

magnimarels
Copy link
Contributor

@magnimarels magnimarels commented May 28, 2024 •
edited
Loading

Added Icelandic translation for the x-data-grid

@mui-bot
Copy link

mui-bot commented May 28, 2024 •
edited
Loading

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running pnpm l10n
  • Verify that you have added an export line in src/locales/index.ts for the new locale.
  • Run pnpm docs:api which should add your new translation to the list of exported interfaces.
  • Clean files with pnpm prettier.

Deploy preview: https://deploy-preview-13283--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 7bd6a74

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 28, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@oliviertassinari oliviertassinari added the l10n localization label May 28, 2024
@LukasTy LukasTy added the component: data grid This is the name of the generic UI component, not the React module! label May 29, 2024
LukasTy
LukasTy reviewed May 29, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 🙏
Could you please sync (merge into) your branch with the latest upstream/master to avoid unwanted changes in the PR? 🤔

@LukasTy LukasTy requested a review from a team May 29, 2024 06:08
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 29, 2024
@LukasTy LukasTy requested review from a team and removed request for LukasTy June 17, 2024 12:41
@LukasTy
Copy link
Member

LukasTy commented Jul 19, 2024

🔔 Gentle ping @mui/xgrid.

MBilalShafi
MBilalShafi approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 👍

@MBilalShafi MBilalShafi enabled auto-merge (squash) July 24, 2024 11:43
@LukasTy LukasTy disabled auto-merge July 24, 2024 14:13
@LukasTy
Copy link
Member

LukasTy commented Jul 24, 2024

Forcing a merge as the e2e website seems to be flaky and would definitely pass. 👌

@LukasTy LukasTy merged commit 09e6df4 into mui:master Jul 24, 2024
16 checks passed
@magnimarels magnimarels deleted the add-icelandic-translation branch July 24, 2024 14:17
@alhabib5565 alhabib5565 mentioned this pull request Aug 19, 2024
Open
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@magnimarels @MBilalShafi @thomasmoon
[l10n] Add Icelandic (is-IS) locale (mui#13283)
242bfad 
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy left review comments

@MBilalShafi MBilalShafi MBilalShafi approved these changes

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@magnimarels @mui-bot @LukasTy @MBilalShafi @oliviertassinari