Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPremium] Pass the api object to events #13893

Merged
merged 2 commits into from
Jul 25, 2024
Merged

[DataGridPremium] Pass the api object to events #13893

merged 2 commits into from
Jul 25, 2024

Conversation

pcorpet
Copy link
Contributor

@pcorpet pcorpet commented Jul 18, 2024

The code would only send it with Pro which would be a regression for clients switching from Pro to Premium.

@pcorpet
[Data Grid] Also send the API with events in Premium.
b6b78f1 
The code would only send it with Pro which would be a regression for clients switching from
Pro to Premium.
@oliviertassinari oliviertassinari changed the title [DataGrid] Also send the API with events in Premium. [DataGrid] Also send the API with events in Premium Jul 18, 2024
@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label Jul 18, 2024
@MBilalShafi MBilalShafi added the CLA: required See https://www.notion.so/mui-org/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 label Jul 20, 2024
@MBilalShafi
Copy link
Member

@pcorpet Thank you for this pull request!
Your changes seem to impact the commercially licensed code. For any changes of this nature, we require contributors to sign the MUI’s Contributor License Agreement (CLA). However, I can’t find a CLA signed that could cover these changes. Please follow the steps at https://mui-org.notion.site/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 to sign the document.

@pcorpet
Copy link
Contributor Author

pcorpet commented Jul 20, 2024

@pcorpet Thank you for this pull request! Your changes seem to impact the commercially licensed code. For any changes of this nature, we require contributors to sign the MUI’s Contributor License Agreement (CLA). However, I can’t find a CLA signed that could cover these changes. Please follow the steps at https://mui-org.notion.site/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 to sign the document.

Done

@zannager
Copy link
Member

@pcorpet, can you please complete the step 3? - Forward the “form submission confirmation” email (check also your spam folder) to team-legal@mui.com to confirm your identity. Also, include the link to the pull request it corresponds to. Thanks.

@zannager zannager added CLA: signed See https://www.notion.so/mui-org/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 and removed CLA: required See https://www.notion.so/mui-org/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 labels Jul 22, 2024
@zannager
Copy link
Member

CLA signed, thanks.

MBilalShafi
MBilalShafi approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @pcorpet for your contribution! 🙏

@MBilalShafi MBilalShafi enabled auto-merge (squash) July 24, 2024 11:37
@mui-bot
Copy link

mui-bot commented Jul 24, 2024

Deploy preview: https://deploy-preview-13893--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 3ea7f4b

@MBilalShafi MBilalShafi merged commit b795564 into mui:master Jul 25, 2024
14 of 15 checks passed
@cherniavskii cherniavskii changed the title [DataGrid] Also send the API with events in Premium [DataGridPremium] Pass the api object to the events Jul 25, 2024
@cherniavskii cherniavskii changed the title [DataGridPremium] Pass the api object to the events [DataGridPremium] Pass the api object to events Jul 25, 2024
@cherniavskii cherniavskii added the plan: Premium Impact at least one Premium user label Jul 25, 2024
@alhabib5565 alhabib5565 mentioned this pull request Aug 19, 2024
Open
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@pcorpet @MBilalShafi @thomasmoon
[DataGrid] Also send the API with events in Premium (mui#13893)
341271f 
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBilalShafi MBilalShafi MBilalShafi approved these changes

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

Assignees
No one assigned
Labels
CLA: signed See https://www.notion.so/mui-org/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 component: data grid This is the name of the generic UI component, not the React module! plan: Premium Impact at least one Premium user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pcorpet @MBilalShafi @zannager @mui-bot @oliviertassinari @cherniavskii