Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] Issue template improvement #13954

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

michelengelen
Copy link
Member


This change adds 2 things:

  1. a selection to the issue template to determine which products are affected
  2. an addition to the cleanup action that labels the issue based on the selection

As a side effect I did add some labels based on the type of issue created

  • Bug issue => labels 'bug 🐛'
  • Feature request => labels 'new feature'
  • etc

@michelengelen michelengelen added the scope: infra Org infrastructure work going on behind the scenes label Jul 23, 2024
@michelengelen michelengelen self-assigned this Jul 23, 2024
@mui-bot
Copy link

mui-bot commented Jul 23, 2024

Deploy preview: https://deploy-preview-13954--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against d0a249c

Copy link
Member

@JCQuintas JCQuintas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements 👍

.github/workflows/issue-cleanup.yml Outdated Show resolved Hide resolved
@michelengelen michelengelen enabled auto-merge (squash) July 23, 2024 14:48
@michelengelen michelengelen merged commit 07afc30 into mui:master Jul 24, 2024
17 checks passed
@michelengelen michelengelen deleted the gh/issue-template-improvement branch July 24, 2024 09:58
labels: ['status: waiting for maintainer']
labels: ['status: waiting for maintainer', 'bug 🐛']
Copy link
Member

@oliviertassinari oliviertassinari Aug 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be mindful that not having the label was done on purpose. Not having the label removes all possible uncertainty: if the label is here, it's because a maintainer added it. Too often developers open issues with the bug template when those are not bugs. With the label added at the start, it means that we have to be mindful of it and double-check each time, so we fix it each time it's wrong.

It's not clear that this will perform better, time will tell 🤷‍♂️

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to trust the author on this, since he was already given the option when entering the "New issue" page. Although I do agree that a lot of opened bug issues are asking for very specific implementation details, but I can still filter them out.

From my experience so far more users opened under the correct category than vice versa

But yeah ... time will tell! :P

Copy link
Member

@oliviertassinari oliviertassinari Aug 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To roll out to the other repositories if we see this working well here.

Today, we have the "waiting for maintainer" label, it's a major difference compared to when we took this decision not to have the label. It likely makes it a lot more OK, like: if the label is here, I know I need to check that the other labels are correct, if it's no longer here, I can except the labels to be correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: infra Org infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants