-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[infra] Issue template improvement #13954
[infra] Issue template improvement #13954
Conversation
Deploy preview: https://deploy-preview-13954--material-ui-x.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvements 👍
labels: ['status: waiting for maintainer'] | ||
labels: ['status: waiting for maintainer', 'bug 🐛'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be mindful that not having the label was done on purpose. Not having the label removes all possible uncertainty: if the label is here, it's because a maintainer added it. Too often developers open issues with the bug template when those are not bugs. With the label added at the start, it means that we have to be mindful of it and double-check each time, so we fix it each time it's wrong.
It's not clear that this will perform better, time will tell 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to trust the author on this, since he was already given the option when entering the "New issue" page. Although I do agree that a lot of opened bug issues are asking for very specific implementation details, but I can still filter them out.
From my experience so far more users opened under the correct category than vice versa
But yeah ... time will tell! :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To roll out to the other repositories if we see this working well here.
Today, we have the "waiting for maintainer" label, it's a major difference compared to when we took this decision not to have the label. It likely makes it a lot more OK, like: if the label is here, I know I need to check that the other labels are correct, if it's no longer here, I can except the labels to be correct.
This change adds 2 things:
As a side effect I did add some labels based on the type of issue created