[DataGridPremium] Fix paste to selected cells #13967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romgrk
added
bug 🐛
|
Deploy preview: https://deploy-preview-13967--material-ui-x.netlify.app/ |
KenanYusuf
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Tested it and it seems to paste in the original order now.
I observed another issue where if you try to copy a cell after previously pasting, the previously pasted cells get reset:
issue.mp4
@romgrk are you able to reproduce this? Shall I create a separate issue if so?
|
That's a bug with the demo code provided by the user, |
cherniavskii
added
plan: Premium
cherniavskii
changed the title
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13703
Fix pasting to multiple selected cells. The root cause is that the selection model is an unordered record of the selected cells, but we were
Object.entries()'ing it, which didn't produce the same ordering as the visible rows.Before: https://codesandbox.io/p/devbox/lck95j?file=%2Fsrc%2FDemo.tsx
After: https://codesandbox.io/p/sandbox/mui-mui-x-x-data-grid-forked-2wzpkz?file=%2Fsrc%2Fdemo.tsx