Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] Revert vale action paths filtering #14038

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Jul 30, 2024

Revert the paths filter, because it skips the action and keeps that item in a pending state. 🙈

If a workflow is skipped due to path filtering, branch filtering, or a commit message, then checks associated with that workflow will remain in a "Pending" state. A pull request that requires those checks to be successful will be blocked from merging.

We already have a filter to run vale only on docs/data, it should be enough. 🤞

Screenshot 2024-07-30 at 16 54 31

@LukasTy LukasTy added core Infrastructure work going on behind the scenes scope: infra Org infrastructure work going on behind the scenes labels Jul 30, 2024
@LukasTy LukasTy self-assigned this Jul 30, 2024
@LukasTy LukasTy requested review from alexfauquette and a team July 30, 2024 13:57
@mui-bot
Copy link

mui-bot commented Jul 30, 2024

Deploy preview: https://deploy-preview-14038--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 4f36347

Copy link

codspeed-hq bot commented Jul 30, 2024

CodSpeed Performance Report

Congrats! CodSpeed is installed 🎉

🆕 3 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks

  • BarChart with big data amount (1.6 s)
  • LineChart with big data amount (1 s)
  • ScatterChart with big data amount (573.1 ms)

@LukasTy LukasTy enabled auto-merge (squash) July 30, 2024 14:04
@LukasTy LukasTy merged commit 64d8236 into mui:master Jul 30, 2024
21 checks passed
@LukasTy LukasTy deleted the fix-vale branch July 30, 2024 14:14
@cherniavskii
Copy link
Member

Thanks @LukasTy
I've seen this in #13781 yesterday, but I thought it's a one-time glitch 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes scope: infra Org infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants