Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[l10n] Improve Vietnamese (vi-VN) locale #14216

Merged
merged 2 commits into from
Aug 15, 2024
Merged

[l10n] Improve Vietnamese (vi-VN) locale #14216

merged 2 commits into from
Aug 15, 2024

Conversation

hungnd-casso
Copy link
Contributor

@hungnd-casso hungnd-casso commented Aug 15, 2024 •
edited
Loading

@mui-bot
Copy link

mui-bot commented Aug 15, 2024 •
edited
Loading

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running pnpm l10n
  • Clean files with pnpm prettier.

Deploy preview: https://deploy-preview-14216--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 553e386

@hungnd-casso hungnd-casso changed the title [DataGrid] Translate vietnamese data grid column management text [l10n] Improve Vietnamese (vi-VN) locale Aug 15, 2024
@hungnd-casso
Copy link
Contributor Author

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running pnpm l10n
  • Clean files with pnpm prettier.

Deploy preview: https://deploy-preview-14216--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 65f02b5

@hungnd-casso
Copy link
Contributor Author

hungnd-casso commented Aug 15, 2024 •
edited
Loading

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running pnpm l10n
  • Clean files with pnpm prettier.

Deploy preview: https://deploy-preview-14216--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 65f02b5

@hungnd-casso hungnd-casso reopened this Aug 15, 2024
@LukasTy LukasTy added component: data grid This is the name of the generic UI component, not the React module! l10n localization labels Aug 15, 2024
LukasTy
LukasTy approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 🙏

@LukasTy LukasTy merged commit f964fef into mui:master Aug 15, 2024
23 of 24 checks passed
@shagg0r shagg0r mentioned this pull request Sep 14, 2024
Open
@alhabib5565 alhabib5565 mentioned this pull request Sep 14, 2024
Open
@mbreadmachine mbreadmachine mentioned this pull request Sep 14, 2024
Open
@KOTTAGENVH KOTTAGENVH mentioned this pull request Sep 15, 2024
Open
@alhabib5565 alhabib5565 mentioned this pull request Sep 18, 2024
Open
@KOTTAGENVH KOTTAGENVH mentioned this pull request Sep 18, 2024
Open
This was referenced Sep 19, 2024
Open
Open
This was referenced Sep 20, 2024
Open
Open
Open
Open
Open
@mbreadmachine mbreadmachine mentioned this pull request Sep 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hungnd-casso @mui-bot @LukasTy