Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] Fix tooltip with horizontal layout #14337

Merged
merged 5 commits into from
Aug 27, 2024

Conversation

alexfauquette
Copy link
Member

Fix #14332

@alexfauquette alexfauquette added regression A bug, but worse component: charts This is the name of the generic UI component, not the React module! labels Aug 26, 2024
@mui-bot
Copy link

mui-bot commented Aug 26, 2024

Deploy preview: https://deploy-preview-14337--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against b6df34e

Copy link

codspeed-hq bot commented Aug 26, 2024

CodSpeed Performance Report

Merging #14337 will not alter performance

Comparing alexfauquette:fix-tooltip-2 (b6df34e) with master (377d5a0)

Summary

✅ 3 untouched benchmarks

Copy link
Member

@JCQuintas JCQuintas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a test to catch this regression in the future?

@@ -0,0 +1,251 @@
import * as React from 'react';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file name has weird capitalisation 😅

@alexfauquette alexfauquette merged commit 89350ce into mui:master Aug 27, 2024
19 checks passed
@alexfauquette alexfauquette deleted the fix-tooltip-2 branch August 27, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! regression A bug, but worse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[charts] BarChart horizontal now breaks the series value passing
3 participants