[core] Use useRtl instead of useTheme to access direction
#14359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasTy
added
core
dosubot
bot
added
the
size:L
|
Deploy preview: https://deploy-preview-14359--material-ui-x.netlify.app/ |
CodSpeed Performance ReportMerging #14359 will not alter performanceComparing Summary
|
alexfauquette
approved these changes
Aug 27, 2024
romgrk
reviewed
Aug 27, 2024
romgrk
reviewed
Aug 27, 2024
Signed-off-by: Lukas Tyla <llukas.tyla@gmail.com>
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
cherniavskii
approved these changes
Aug 29, 2024
This was referenced Sep 20, 2024
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #13363.
When working on #14142 and noticing that we are reverting back to
@mui/systemas a peer dependency I thought that it would make sense for all packages to actually "need" that peer dependency to function properly.This is also a stepping stone for PigmentCSS support.
It also has the added benefit of further reducing the coupling with
@mui/material.Review from the Data Grid team is essential as it touches the store.
I've done some testing to ensure that it functions as it currently does, but at least a second pair of eyes is essential.