[DataGridPro] Fix pinned columns in RTL mode #14586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenanYusuf
added
bug 🐛
KenanYusuf
commented
Sep 11, 2024
Comment on lines
+459
to
+466
| refs.fillerLeft = findGridElement( | ||
| apiRef.current, | ||
| isRtl ? 'filler--pinnedRight' : 'filler--pinnedLeft', | ||
| ); | ||
| refs.fillerRight = findGridElement( | ||
| apiRef.current, | ||
| isRtl ? 'filler--pinnedLeft' : 'filler--pinnedRight', | ||
| ); |
There was a problem hiding this comment.
Inverting these fixes an issue where pinned column viewport fillers were resizing the opposite sides:
Screen.Recording.2024-09-11.at.15.26.22.mov
KenanYusuf
commented
Sep 11, 2024
Comment on lines
+178
to
+179
| position: isRtl ? 'right' : 'left', | ||
| filterFn: (index) => (isRtl ? index < colIndex! : index > colIndex!), |
There was a problem hiding this comment.
Inverting the position and filter function fixes an issue where the other cells within the pinned columns were not being resized:
Screen.Recording.2024-09-11.at.16.07.32.mov
|
Deploy preview: https://deploy-preview-14586--material-ui-x.netlify.app/ |
KenanYusuf
commented
Sep 11, 2024
| pinnedLeftLength: number, | ||
| ) { | ||
| const factor = isRtl ? -1 : 1; |
There was a problem hiding this comment.
I don't fully understand the purpose of this offset, but removing the factor fixes this additional space between right pinned cells and non-pinned cells:
1 task
cherniavskii
added
plan: Pro
cherniavskii
changed the title
cherniavskii
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Nice, we clearly missed this in Argos 👍🏻
arthurbalduini
pushed a commit
to arthurbalduini/mui-x
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14245
Before: codesandbox
After: codesandbox
Note: Resizing left pinned columns in RTL mode has the same issue that LTR see on right pinned columns (#12852). This PR does not attempt to fix that, as there is already a PR in progress for this issue (#12979).