Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename Database.Name -> Database.DBName #62

Merged
merged 1 commit into from
Dec 24, 2022
Merged

rename Database.Name -> Database.DBName #62

merged 1 commit into from
Dec 24, 2022

Conversation

muir
Copy link
Owner

@muir muir commented Dec 24, 2022

Breaking change
Database.Name renamed for clarity.

@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2022

Codecov Report

Base: 81.30% // Head: 81.30% // No change to project coverage 👍

Coverage data is based on head (3a43fb1) compared to base (c00b470).
Patch coverage: 90.90% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #62   +/-   ##
=======================================
  Coverage   81.30%   81.30%           
=======================================
  Files          12       12           
  Lines        1198     1198           
=======================================
  Hits          974      974           
  Misses        157      157           
  Partials       67       67           
Flag Coverage Δ
go_tests 9.59% <0.00%> (ø)
mysql_tests 49.41% <54.54%> (ø)
pg_tests 54.24% <73.68%> (ø)
singlestore_tests 47.16% <63.63%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api.go 93.47% <60.00%> (ø)
apply.go 83.14% <100.00%> (ø)
lsmysql/check.go 84.61% <100.00%> (ø)
lsmysql/mysql.go 78.54% <100.00%> (ø)
lspostgres/postgres.go 78.18% <100.00%> (ø)
lssinglestore/singlestore.go 71.14% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@muir muir merged commit 575f87a into main Dec 24, 2022
@muir muir deleted the rename branch December 24, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants