Search Flights By Type Rating and Aircraft ICAO Type Code #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FatihKoz
changed the title
Add name to the collection, so it can be used in the search form instead of (or together with) the type code.
Replace `!empty()` with `filled()` , thanks to @PaintSplasher for the test and solution.
|
This looks fantastic. Thanks for the corrections! Can you amend your PR description to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @BossOfGames 's idea and implementation for the usage of
whereIn()as a new search criteria [WhereCriteria], I slightly changed his Type Rating based query to improve performance and added Aircraft ICAO Type Code based search capabilities. [FlightRepository]According to VA settings, both $type_ratings and $icao_codes are built upon user capabilities (restricted settings) or all (relaxed settings). [FlightController]
Added both fields with conditional checks to default theme. [search.blade]
Enhances #1879 and provides other changes for this feature to be used with any theme.
Closes #1851