Skip to content

Commit

Permalink
Remove unneeded multi getter
Browse files Browse the repository at this point in the history
  • Loading branch information
nakabonne committed Dec 6, 2020
1 parent 46e20b8 commit fc73b4c
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 140 deletions.
47 changes: 2 additions & 45 deletions cache/cache.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,9 @@
// store content on a pbgopy server.
package cache

import (
"errors"
)
import "errors"

var (
ErrNotFound = errors.New("not found")
)
var ErrNotFound = errors.New("not found")

// Getter wraps a method to read from cache.
type Getter interface {
Expand All @@ -45,42 +41,3 @@ type Cache interface {
Putter
Deleter
}

type multiGetter struct {
getters []Getter
}

// MultiGetter combines a lit of getters into a single getter.
func MultiGetter(getters ...Getter) Getter {
all := make([]Getter, 0, len(getters))
for _, r := range getters {
if mg, ok := r.(*multiGetter); ok {
all = append(all, mg.getters...)
} else {
all = append(all, r)
}
}
return &multiGetter{
getters: all,
}
}

func (mg *multiGetter) Get(key interface{}) (interface{}, error) {
if len(mg.getters) == 0 {
return nil, ErrNotFound
}
if len(mg.getters) == 1 {
return mg.getters[0].Get(key)
}
var firstErr error
for i := range mg.getters {
e, err := mg.getters[i].Get(key)
if firstErr == nil && err != nil {
firstErr = err
}
if err == nil {
return e, nil
}
}
return nil, firstErr
}
90 changes: 0 additions & 90 deletions cache/cache_test.go

This file was deleted.

3 changes: 0 additions & 3 deletions commands/serve.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ type serveRunner struct {
ttl time.Duration
basicAuth string

// random data used as an additional input for hashing data.
salt []byte
cache cache.Cache
stdout io.Writer
stderr io.Writer
Expand Down Expand Up @@ -97,7 +95,6 @@ func (r *serveRunner) newServer() *http.Server {
}

func (r *serveRunner) handle(w http.ResponseWriter, req *http.Request) {

switch req.Method {
case http.MethodGet:
data, err := r.cache.Get(dataCacheKey)
Expand Down
4 changes: 2 additions & 2 deletions datasize/datasize.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func (b ByteSize) EBytes() float64 {
func (b ByteSize) String() string {
switch {
case b == 0:
return fmt.Sprint("0B")
return "0B"
case b%EB == 0:
return fmt.Sprintf("%dEB", b/EB)
case b%PB == 0:
Expand Down Expand Up @@ -134,7 +134,7 @@ ParseLoop:
goto Overflow
}

c = c - '0'
c -= '0'
val *= 10

if val > val+uint64(c) {
Expand Down

0 comments on commit fc73b4c

Please sign in to comment.