Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the way to take offset so that it can decode no matter the number of metrics is #12

Merged
merged 6 commits into from
Jul 4, 2021

Conversation

nakabonne
Copy link
Owner

@nakabonne nakabonne commented Jul 4, 2021

This PR does:

  • write actually encoded data points for each metric
  • reset encoder params used for computation (like deltas) whenever flushing
  • also stop using gzip for now.

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2021

Codecov Report

Merging #12 (c55ac69) into main (167b85e) will increase coverage by 7.11%.
The diff coverage is 57.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   54.24%   61.35%   +7.11%     
==========================================
  Files          18       18              
  Lines         861      877      +16     
==========================================
+ Hits          467      538      +71     
+ Misses        330      259      -71     
- Partials       64       80      +16     
Impacted Files Coverage Δ
storage.go 52.34% <27.28%> (+3.95%) ⬆️
disk_partition.go 57.41% <57.15%> (+22.12%) ⬆️
encoding.go 44.87% <72.23%> (+22.77%) ⬆️
bstream.go 84.42% <100.00%> (+3.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 167b85e...c55ac69. Read the comment docs.

@nakabonne nakabonne changed the title Add check if file to be mmapped is empty Fix the way to take offset so that it can decode no matter the number of metrics is Jul 4, 2021
@nakabonne nakabonne merged commit a832e87 into main Jul 4, 2021
@nakabonne nakabonne deleted the add-empty-check branch July 4, 2021 09:10
@github-actions github-actions bot mentioned this pull request Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants