Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure to remove the oldest segment when flushing #34

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Conversation

nakabonne
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2021

Codecov Report

Merging #34 (90f389b) into main (e7ef1a5) will decrease coverage by 0.41%.
The diff coverage is 64.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   62.74%   62.34%   -0.40%     
==========================================
  Files          19       19              
  Lines        1111     1123      +12     
==========================================
+ Hits          697      700       +3     
- Misses        288      292       +4     
- Partials      126      131       +5     
Impacted Files Coverage Δ
storage.go 51.38% <57.90%> (-0.85%) ⬇️
disk_wal.go 49.66% <70.00%> (-1.38%) ⬇️
wal.go 66.67% <0.00%> (+16.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7ef1a5...90f389b. Read the comment docs.

@nakabonne nakabonne merged commit cf153b5 into main Oct 29, 2021
@nakabonne nakabonne deleted the remove-oldest branch October 29, 2021 02:12
@github-actions github-actions bot mentioned this pull request Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants