Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add aarch64 manylinux wheel builds #9

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

no23reason
Copy link
Contributor

Use QEMU to enable builds of native aarch64 manylinux wheels. Also upgrade cibuildwheel to the latest version.
Inspired by https://cibuildwheel.readthedocs.io/en/stable/faq/#emulation
The aarch64 builds take +/- 10 minutes per python version, so the total build time increases quite a lot :( to reduce it somehow, maybe it would be worth it to drop support for end-of-life python versions 3.6 and 3.7?

Use QEMU to enable builds of native aarch64 manylinux wheels.
Also upgrade cibuildwheel to the latest version.
@no23reason
Copy link
Contributor Author

no23reason commented Oct 20, 2023

Here is a sample run with a slightly different version (I was able to simplify it for the PR, but the semantics are the same): https://github.com/no23reason/sqlean.py/actions/runs/6586202390

@liry
Copy link

liry commented Oct 25, 2023

@nalgeon could you please review this?

@nalgeon
Copy link
Owner

nalgeon commented Nov 1, 2023

Not sure about this. Why do you folks need an ARM Linux build at all? Do you actually use Linux on ARM processors?

@no23reason
Copy link
Contributor Author

Yes, unfortunately I do :( the use case is running an image that uses the sqlean dependnecy inside Docker and Docker compose on an Apple Silicon host.

@no23reason
Copy link
Contributor Author

But I understand your concerns, the builds do take for ever :/ we develop some python wheels internally at our company and the support for the ARM/Linux version of our wheels also made our builds take twice as long compared to the x86 ones.

@nalgeon nalgeon merged commit 0800e69 into nalgeon:main Nov 12, 2023
7 checks passed
@nalgeon
Copy link
Owner

nalgeon commented Nov 12, 2023

Fair enough. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants