Fs UI bug fixes #464
Open
Fs UI bug fixes #464
+62
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
netalondon
commented
Sep 16, 2024
netalondon
commented
- "Select existing folder" resulted in a failure if a folder was already selected.
- Hardware Simulator: If there were no HDL project directories, the chip menu would still contain the project 1 chips. Choosing them resulted in a file not found error.
netalondon
force-pushed
the
fs-ui-bugs
branch
from
7e1100f
to
b768b2d
Compare
netalondon
force-pushed
the
fs-ui-bugs
branch
from
b768b2d
to
e7d6dc0
Compare
DavidSouther
requested changes
Sep 17, 2024
| @@ -21,6 +21,43 @@ import { | |||
| removeLocalAdapterFromIndexedDB, | |||
| } from "./base/indexDb.js"; | |||
|
|
|||
| async function cloneTree( | |||
There was a problem hiding this comment.
This should probably be in a "file system utilities" file somewhere
| @@ -10,7 +10,6 @@ import "../pico/button-group.scss"; | |||
| import "../pico/property.scss"; | |||
| import { TrackingDisclosure } from "../tracking"; | |||
| import { getVersion, setVersion } from "../versions"; | |||
| // import { useDialog } from "./dialog"; | |||
There was a problem hiding this comment.
It is removed, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.