ogma-core: Remove dependency on IfElse

[ivanperez-keera]

Description

The dependency on IfElse is quite unnecessary: it seems like the only function we use from that library is awhen :: Monad m => Maybe a -> (a -> m ()) -> m (), which is a type-specialized version of Data.Foldable.for_.. Since the latter is in base, we can simplify Ogma by removing the dependency on IfElse.

Type

• Management: Reduce technical debt, in compliance with style guide.

Additional context

None.

Requester

• Ivan Perez

Method to check presence of bug

Not applicable (not a bug).

Expected result

IfElse is not required by any library in ogma.

Desired result

IfElse is not required by any library in ogma.

Proposed solution

Replace calls to awhen with calls to for_

Remove the dependency on IfElse.

Further notes

None.

[ivanperez-keera]

Change Manager: Confirmed that the issue exists.

[ivanperez-keera]

Technical Lead: Confirmed that the issue should be addressed.

[ivanperez-keera]

Technical Lead: Issue scheduled for fixing in Ogma 1.4.1.
Fix assigned to: @ivanperez-keera.

[ivanperez-keera]

Implementor: Solution implemented, review requested.

[ivanperez-keera]

Change Manager: Verified that:

• Solution is implemented:
  • The code proposed compiles passes the tests. Details:
    • Build logs:
      • https://github.com/nasa/ogma/actions/runs/10980588665/job/30486565255
      • https://github.com/nasa/ogma/actions/runs/10980588664/job/30486565078
    • Build log archives:
      • logs_28691603236.zip
      • logs_28691603237.zip
  • The solution proposed fixes the issues described.
    The following docker file checks that no cabal package depends on IfElse, in which case it prints the message success:

    FROM ubuntu:focal
    
    RUN apt-get update
    
    RUN apt-get install --yes git
    
    SHELL ["/bin/bash", "-c"]
    CMD git clone $REPO \
        && cd $NAME \
        && git checkout $COMMIT \
        && ! grep -niHre 'IfElse' --include='*.cabal' ogma** \
        && echo "Success"

    Command:

    docker run -e "REPO=https://github.com/ivanperez-keera/ogma" -e "NAME=ogma" -e PAT="ogma-" -e "COMMIT=0db6542adbeeba654f4d011126a30a6adeeadb81" -it ogma-verify-150
    

• Implementation is documented. Details:
  No need for updates to documentation.
• Change history is clear.
• Commit messages are clear.
• Changelogs are updated.
• Examples are updated. Details:
  No examples affected.
• Required version bumps are evaluated. Details:
  No update needed; the improvement reduces dependencies.

[ivanperez-keera]

Change Manager: Implementation ready to be merged.