Skip PoetryExecutor if poetry is not found

[kzrnm]

poe cannot run PoetryExecutor if poetry is set as an alias instead of $PATH.

I want to skip PoetryExecutor when poetry is not found.

[nat-n]

Hi @kzrnm , I'm curious to know more about your use case for this? Though I guess this behaviour makes sense if you have a project with a poetry managed local venv, but just don't have poetry somewhere discoverable for whatever reason.

Though I think falling back to the simple executor could be surprising.

[kzrnm]

# Microsoft.PowerShell_profile.ps1
Set-Alias poetry "${env:APPDATA}\pypoetry\venv\Scripts\poetry.exe"

I use poetry via alias on PowerShell, so that python interpreter cannot find poetry command and raise FileNotFoundError at PoetryExecutor.

poethepoet/poethepoet/executor/poetry.py

Lines 80 to 85 in 903ed9a

	Popen(
	(self._poetry_cmd(), "env", "info", "-p"),
	stdout=PIPE,
	cwd=self.context.config.project_dir,
	env=clean_env,
	)

SimpleExecutor work properly.

In poetry run, poetry adds its venv directory to the $PATH of the subprocess.

Example

Git bash,

virtualenvs.in-project = true

[tool.poe.tasks.env]
shell = "/usr/bin/env | /usr/bin/grep ^PATH="

$ env PATH="" $APPDATA/pypoetry/venv/Scripts/poetry run poe env
Poe => /usr/bin/env | /usr/bin/grep ^PATH=
PATH=/mingw64/bin:/usr/bin:/c/Users/kzrnm/bin:/z/poethepoet/.venv/Scripts

PowerShell

virtualenvs.in-project = false

[tool.poe.tasks.env]
shell = "(dir Env:PATH).Value"

PS> $env:PATH=""
PS> & "$env:APPDATA/pypoetry/venv/Scripts/poetry" run poe env
Poe => (dir Env:PATH).Value
C:\Program Files\PowerShell\7;C:\Users\kzrnm\AppData\Local\pypoetry\Cache\virtualenvs\poethepoet-zPZo9g_N-py3.9\Scripts;

[nat-n]

Thanks for the update. I'm happy to merge this once we work out what's going on with the tests.

Although maybe it could still be improved:

I wonder if it would be a good idea to log a warning when poe fallback to the SimpleExecutor in a poetry governed project because the poetry executable can't be found.

Alternatively I wonder if it would be better still if poe were to specifically check for poetry at $APPDATA/pypoetry/venv/Scripts/poetry if running on windows and poetry doesn't show up on the path?

[kzrnm]

@nat-n I updated fix/poetry to the latest.

i don't know why, but CI have worked.