Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open env files in utf-8 mode explicitly #179

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Open env files in utf-8 mode explicitly #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c24ae95
Open env files in utf-8 mode explicitly #176
nat-n Oct 25, 2023
e3baa10
Try disable windows test for python 3.8
nat-n Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
python-version: ['3.8', '3.9', '3.10', '3.11']
exclude: # TODO: remove this when pip is fixed
- os: Windows
python-version: '3.11'
python-version: '3.8'

runs-on: ${{ matrix.os }}-latest
steps:
Expand Down
2 changes: 1 addition & 1 deletion poethepoet/env/cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def get(self, envfile_path_str: str) -> Dict[str, str]:
envfile_path = self._project_dir.joinpath(Path(envfile_path_str).expanduser())
if envfile_path.is_file():
try:
with envfile_path.open() as envfile:
with envfile_path.open(encoding="utf-8") as envfile:
result = parse_env_file(envfile.readlines())
except ValueError as error:
message = error.args[0]
Expand Down