Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DiscardPerSubject stream option #124

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Conversation

mfuhol-weka
Copy link
Contributor

Hi there!

This PR adds support for DiscardNewPerSubject flag into Jetstream CRD and controller itself

In NATS server of version 2.9.0 there's option DiscardNewPerSubject which is available through CLI (>= 0.0.35) using --[no-]discard-per-subject flag or through jsmapi (>= 0.0.35) using DiscardNewPer option.

@joaovitor-cx
Copy link

Great @mfuhol-weka

It would be great to have nats stream purge per subject too.

Copy link
Member

@bruth bruth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bruth bruth requested a review from wallyqs July 14, 2023 18:59
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs wallyqs merged commit 24881bc into nats-io:main Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants