Fix nats-server-config-reloader for k8s secrets #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkralik
added a commit
to plgd-dev/hub
that referenced
this pull request
Jun 9, 2023
|
Thanks so much for the report and the fix!! 🙏 I will make a release with this change next week. |
Fixes nats-io#130 To fix this issue, the commit ensures that when a file is deleted, the Inotify watches immediately unregister it and then attempt to periodically re-register the file every second until the operation succeeds. This guarantees that the file will continue to be monitored reliably even after deletion.
jkralik
added a commit
to plgd-dev/hub
that referenced
this pull request
Jun 13, 2023
* services: reload certificates when it is changed Hub stopped working because of expired mTLS certificates, even though the certs were correctly auto-rotated in the k8s cluster. * charts: set cert-manager.io/private-key-rotation-policy to ingress * charts: rotate mongo certificates when it has been changed * nats-server-config-reloader: expose plgd image until fix accepted nats-io/nack#131
piotrpio
reviewed
Jun 27, 2023
Co-authored-by: Piotr Piotrowski <piotrpiotrowski94@gmail.com>
Sure. We utilize |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #130
To fix this issue, the commit ensures that when a file is deleted, the Inotify watches immediately unregister it and then attempt to periodically re-register the file every second until the operation succeeds. This guarantees that the file will continue to be monitored reliably even after deletion.