Provide e2e testing based on kuttl #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@wallyqs What do you think about the structure? Right now, it checks stream creation only. If you agree I can create the required Github actions too and then add more cases. Only issue I need to track down is RBAC. NACK helm chart installs RBAC but they are not removed by |
|
I think structure looks great, it is easy to follow what is happening in each of the steps. |
|
I think we can consider this finish for at least checking the stream creation. Here is the workflow result for e2e testing. https://github.com/1995parham/nack/actions/runs/7170032922/job/19521815874 |
|
This is awesome, thanks @1995parham! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide e2e testing using kuttl. Closes #59