Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support to .NET 8 #3132

Closed
lock9 opened this issue Feb 9, 2024 · 4 comments · Fixed by #3180
Closed

Add Support to .NET 8 #3132

lock9 opened this issue Feb 9, 2024 · 4 comments · Fixed by #3180
Labels
discussion Initial issue state - proposed but not yet accepted

Comments

@lock9
Copy link
Contributor

lock9 commented Feb 9, 2024

Summary or problem description
It seems that the compiler is not compatible with the latest .NET version (8). It's not possible to update it to make it compatible with .NET 8 because the Neo library doesn't support it.

Do you have any solution you want to propose?
Add support to support .NET 8. It's impossible to update only the compiler because it depends on Neo. Jimmy mentioned using .NET Standard, but that will demand more refactoring than just adding support to .NET 8.

Where in the software does this update apply to?

  • Compiler
  • Other: Core Lib
@lock9 lock9 added the discussion Initial issue state - proposed but not yet accepted label Feb 9, 2024
@cschuchardt88
Copy link
Member

@Jim8y @shargon if we are do this DO NOT remove net7.0.

add this line

<TargetFrameworks>netstandard2.1;net7.0;net8.0</TargetFrameworks>

@lock9
Copy link
Contributor Author

lock9 commented Feb 14, 2024

Thanks @cschuchardt88, that seems to be the ideal solution.

Should I create another issue in the devpack repository to update it once this is implemented? (if it's implemented at all).

@shargon
Copy link
Member

shargon commented Feb 14, 2024

@Jim8y @shargon if we are do this DO NOT remove net7.0.

add this line

<TargetFrameworks>netstandard2.1;net7.0;net8.0</TargetFrameworks>

#3056 (comment)

@cschuchardt88
Copy link
Member

cschuchardt88 commented Feb 15, 2024

That comment was for ONLY dotnet 7.0 latest. Read whole thing 1st (all comments). Plus we can still support older versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Initial issue state - proposed but not yet accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants