Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to dotnet 8.0 #3180

Merged
merged 5 commits into from
Mar 25, 2024
Merged

Upgrade to dotnet 8.0 #3180

merged 5 commits into from
Mar 25, 2024

Conversation

cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Mar 25, 2024 •
edited
Loading

Change Log

  • Added support for net8.0
  • Changes all files required for net8.0 support.
  • Upgraded nuget packages

Closes #3132

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cschuchardt88
Copy link
Member Author

@shargon @Jim8y ready for review

@shargon shargon merged commit 65822cf into neo-project:master Mar 25, 2024
6 checks passed
@shargon shargon deleted the dotnet-upgrade branch March 25, 2024 09:44
@mialbu mialbu mentioned this pull request Mar 25, 2024
Closed
@cschuchardt88 cschuchardt88 restored the dotnet-upgrade branch March 25, 2024 15:43
@roman-khimov roman-khimov added this to the v3.7.0 milestone May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

@Jim8y Jim8y Jim8y approved these changes

@vncoelho vncoelho Awaiting requested review from vncoelho

@superboyiii superboyiii Awaiting requested review from superboyiii

Assignees
No one assigned
Labels
waiting for review
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.

Add Support to .NET 8
4 participants
@cschuchardt88 @shargon @Jim8y @roman-khimov