Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of deprecated NamedCurve enum #3236

Closed
AnnaShaleva opened this issue May 16, 2024 · 0 comments · Fixed by #3273
Closed

Get rid of deprecated NamedCurve enum #3236

AnnaShaleva opened this issue May 16, 2024 · 0 comments · Fixed by #3273
Labels
enhancement Type - Changes that may affect performance, usability or add new features to existing modules.
Milestone
v3.8.0

Comments

@AnnaShaleva
Copy link
Member

Summary or problem description
Should be a part of 3.8. Starting from #3209 NamedCurve is deprecated and not needed anymore. We need to remove it.

Also, this enum is used in native CryptoLib in #3234, but may safely be replaced by NamedCurveHash, see the https://github.com/neo-project/neo/pull/3234/files#r1601108804.

Do you have any solution you want to propose?
Remove NamedCurve. Replace all usages by NamedCurveHash with necessary additional value range checks where needed.

Where in the software does this update applies to?

  • Native contracts
@AnnaShaleva AnnaShaleva added the discussion Initial issue state - proposed but not yet accepted label May 16, 2024
@AnnaShaleva AnnaShaleva added this to the v3.8.0 milestone May 16, 2024
@AnnaShaleva AnnaShaleva mentioned this issue May 16, 2024
Merged
12 tasks
@AnnaShaleva AnnaShaleva added enhancement Type - Changes that may affect performance, usability or add new features to existing modules. and removed discussion Initial issue state - proposed but not yet accepted labels May 17, 2024
AnnaShaleva added a commit that referenced this issue May 23, 2024
@AnnaShaleva
Native: remove deprecated NamedCurve enum
d63f3a7 
3.7.0 (and a batch of 3.7.*) is out, which means that users can see the
"Obsolete" warning for NamedCurve enum and migrate to NamedCurveHash.

Close #3236.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@AnnaShaleva AnnaShaleva mentioned this issue May 23, 2024
Merged
9 tasks
NGDAdmin pushed a commit that referenced this issue May 27, 2024
@AnnaShaleva @shargon
Native: remove deprecated NamedCurve enum (#3273)
59bd092 
3.7.0 (and a batch of 3.7.*) is out, which means that users can see the
"Obsolete" warning for NamedCurve enum and migrate to NamedCurveHash.

Close #3236.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Co-authored-by: Shargon <shargon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Type - Changes that may affect performance, usability or add new features to existing modules.
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging a pull request may close this issue.

Native: remove deprecated NamedCurve enum neo-project/neo
1 participant
@AnnaShaleva