New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temp Fix Annotations/Warnings #3196

Merged

shargon merged 1 commit into neo-project:master from cschuchardt88:annotations-temp-remove

Apr 18, 2024

Member

cschuchardt88 commented Apr 17, 2024 •

edited

Loading

Change Log

Temp workaround until someone has time to convert Neo.csproj to <Nullable>enable</Nullable>

Closes Too much warnings on every PR "Unchanged files with check annotations (beta)" #3185

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules


          Fixes

Member Author

cschuchardt88 commented Apr 17, 2024

@shargon @vncoelho @Jim8y
Review Please

Member

vncoelho commented Apr 17, 2024

@cschuchardt88 looks good, I can soon check with attention.
I think until next Thursday would be better to me.

Jim8y approved these changes

View reviewed changes

shargon approved these changes

View reviewed changes

shargon merged commit 13905e1 into neo-project:master

6 checks passed

shargon deleted the annotations-temp-remove branch

April 18, 2024 06:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet