feat: add "empty state" messages #284
Conversation
alexfedosov
force-pushed
the
alexfedosov/better-texts-for-empty-state
branch
from
b66582b
to
b794494
Compare
src/commands/projects.ts
Outdated
|
|
||
| if (!sharedProjects.length && !props.orgId) { | ||
| out.text('\nNo projects have been shared with you\n'); | ||
| } |
There was a problem hiding this comment.
out.write() and out.text() behave differently, causing a different output order. Perhaps we should come up with a better abstraction for printing text (especially, with formatting options)
There was a problem hiding this comment.
I think we just need to update text method to push to same chunks array as write does
There was a problem hiding this comment.
Do you want my help with fixing it's behavior?
There was a problem hiding this comment.
I agree!
Do you want my help with fixing it's behavior?
That should be straightforward, let me try first :)
There was a problem hiding this comment.
@duskpoet I think I figured out a better abstraction for adding optional messages to tables in case data is empty edf5a5c (#284)
What do you think?
alexfedosov
changed the title
| @@ -263,4 +263,3 @@ created_at: 2019-01-01T00:00:00Z | |||
| updated_at: 2019-01-01T00:00:00Z | |||
| " | |||
| `; | |||
|
|
|||
There was a problem hiding this comment.
did you manually edit this file? :)
There was a problem hiding this comment.
I think linter added that change for me, but I couldn't figure out why
|
It would be nice if you can add at least one test that covers an empty list case |
I think `neonctl` could be a bit more user friendly at least in the beginning. Before: <img width="673" alt="Screenshot 2024-10-04 at 09 38 41" src="https://github.com/user-attachments/assets/8ba24eae-ddcd-4503-b5a1-ea84bc4d490f"> <img width="683" alt="Screenshot 2024-10-04 at 09 38 18" src="https://github.com/user-attachments/assets/7760693b-13f6-4f0f-bc9d-6f69f86b8a0e"> After: <img width="604" alt="Screenshot 2024-10-04 at 09 36 29" src="https://github.com/user-attachments/assets/ec6c0901-c925-467b-8c92-f83d293a49df"> <img width="685" alt="Screenshot 2024-10-04 at 09 37 11" src="https://github.com/user-attachments/assets/0c02ed2e-dbc1-4a46-9689-828b9ed94797">
# [2.0.0](v1.37.0...v2.0.0) (2024-10-07) ### Bug Fixes * create-app should generate dev/ not dev- branch names ([b916a14](b916a14)), closes [#262](#262) ### chore * remove deprecated flags related to primary branch ([#283](#283)) ([b4e8b9c](b4e8b9c)) ### Features * add "empty state" messages ([#284](#284)) ([2123de3](2123de3)) ### BREAKING CHANGES * The deprecated set-primary branch command has been removed, deprecated --allow-list and --ip-primary-only project update flags have been removed, --primary-only flag from the ip-allow command has been removed
I think
neonctlcould be a bit more user friendly at least in the beginning.Before:
After: