-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Nornir 3.x and refactor inventory to support multiple SOT #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvanderaa
approved these changes
May 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor update that would not be harmful to merge in.
Co-authored-by: Josh VanDeraa <jv@networktocode.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is refactoring how the project is managing the inventory to allow multiple inventories to coexist.
In the process, I upgraded Nornir to the latest version.
I moved the inventory for Netbox IN
network_importer.adapters.netbox_api
and I created a similar inventory for Nautobot as well.Also, I started to remove the license at the top of some files to align with other NTC projects but I haven't checked all files.
I think we should be good to merge this PR into
add_nautobot
when the tests are passing but here is a list of TODO that we need to address before merging into develop:Configuration File Changes
[inventory]
fqdn
,filter
anduse_primary_ip
have been removed from the inventory section, these settings are now part of the NetboxAPIInventory settingssupported_platforms
has been moved to the inventory section, it was previously under[netbox]
[inventory.settings]
is available and everything in this section will be passed to the inventory class at runtime. This allow each inventory to define and validate its own settings.[netbox]
&[nautobot]
Both sections have been removed from the main configuration and are now defined within each adapter under
network_importer.adapters.ADAPTER_NAME.settings
[adapters]
network_params
has been renamed tonetwork_settings
sot_params
has been renamed tosot_settings