Fix undo toast rendering #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
requested review from
skjnldsv,
juliushaertl and
GretaD
and removed request for
skjnldsv
When a long text is provided for the undo toast, the text gets mixed with the button. It was fiine for the close button as 'padding-right: 34px;' was just right for it. This PR moves to flex layout to make the toast more responsive. + Add 'display: flex' to the toast and to the undo button container + Remove the 'position: absolute' for the close and undo buttons so they get placed by the flex algo + add some margin-right to the undo button because it was to close of the text + Change the padding to '0px 12px' as 12px top and bottom is too much when the close and undo button are not placed absolutely Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
fix/toast_rendering
branch
from
5a0ec42
to
6bc4f7b
Compare
GretaD
approved these changes
May 12, 2022
|
this fixes the undo when you delete a comment on files too |
This was referenced Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a long text is provided for the undo toast, the text gets mixed with the button. It was fine for the close button, as
padding-right: 34px;was just right for it.This PR moves to flex layout to make the toast more responsive.
display: flexto the toast and to the undo button container.position: absolutefor the close and undo buttons, so they get placed by the flex algo.margin-leftto the undo button because it was too close to the text.6px 12pxas12pxtop and bottom is too much when the close and undo button are not placed absolutely.toast.scssis loaded multiple time, so we will have to wait until all@nextcloud/packages and apps update to the latest version to see some improvements without!important.Fixes nextcloud/mail#6364