Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix z-index for deck sidebar #3884

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Fix z-index for deck sidebar #3884

merged 1 commit into from
Jun 28, 2022

Conversation

Raudius
Copy link
Contributor

@Raudius Raudius commented Jun 28, 2022

The sidebar would previously render above the user menu (logout, settings, etc)

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

The sidebar would previously render above the user menu (logout, settings, etc)

Signed-off-by: Raul <r.ferreira.fuentes@gmail.com>
@cypress
Copy link

cypress bot commented Jun 28, 2022



Test summary

5 0 0 0


Run details

Project deck
Status Passed
Commit 4b8f14b7e0 ℹ️
Started Jun 28, 2022 12:18 PM
Ended Jun 28, 2022 12:19 PM
Duration 01:43 💡
OS Linux Ubuntu - 20.04
Browser Electron 100

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@julien-nc julien-nc self-requested a review June 28, 2022 12:32
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Works fine.

I wonder why it was set to such a high value. Maybe this broke because the user menu z-index was changed in the server's css.

@julien-nc
Copy link
Member

CI failure is not related.

@Raudius Raudius merged commit 00cf159 into master Jun 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the enh/fix_sidebar branch June 28, 2022 12:39
@Raudius
Copy link
Contributor Author

Raudius commented Jun 28, 2022

/backport to stable24

@Raudius
Copy link
Contributor Author

Raudius commented Jun 28, 2022

/backport to stable23

@Raudius
Copy link
Contributor Author

Raudius commented Jun 28, 2022

/backport to stable22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants