Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the default language of the template to English (USA). #3015

Conversation

gokaysatir
Copy link
Contributor

Signed-off-by: Gökay Şatır gokaysatir@gmail.com

  • Resolves: #
  • Target version: main

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@gokaysatir
Copy link
Contributor Author

@juliushaertl hello, below commit has wrong default language for the template files. I set the default to English (USA) in this commit.
#3000

Sorry for the forgotten bit.

@juliushaertl
Copy link
Member

Weren't the templates language agnostic so they could pick up the users language in the past? Is this now forcing to be English (USA)?

@gokaysatir
Copy link
Contributor Author

Weren't the templates language agnostic so they could pick up the users language in the past? Is this now forcing to be English (USA)?

Yes that's right. But there is a minor thing to improve there. Nextcloud seems to use the document.odt file (not a template) as a template. There is also a template file - document.ott inside the "emptyTemplates" folder but it doesn't seem to be used.

So i updated the used one (with the *.odt extension) and forgot to update the language. A better fix would be using the "document.ott" template file.

@juliushaertl
Copy link
Member

Ah, that makes sense indeed. I'll check what changed there that the ott is no used.

Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
@juliushaertl juliushaertl force-pushed the private/gokay/update-writer-template-for-dark-mode-fix branch from aa27c30 to d7a9a54 Compare June 15, 2023 21:18
@juliushaertl juliushaertl merged commit a6f4193 into nextcloud:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants