-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Wopi): Mark sensitive parameter as such #3042
fix(Wopi): Mark sensitive parameter as such #3042
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also register via IRegistrationContext::registerSensitiveMethods()
for PHP < 8.2.
Hmm so that means nextcloud/server#39040 is actually not needed anymore? |
5825cd1
to
3161306
Compare
Passing run #468 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
aye |
Signed-off-by: Joas Schilling <coding@schilljs.com>
3161306
to
6f3f8b8
Compare
/backport to stable27 |
/backport to stable26 |
/backport to stable25 |
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
The backport to stable25 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable25
git pull origin stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Ref nextcloud/server#39040
This is only effective in PHP 8.2+ but it's the better and our future approach so doing both in parallel