Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add config option mobile_editing #3141

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

luka-nextcloud
Copy link
Contributor

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

Signed-off-by: Luka Trovic <luka@nextcloud.com>
@cypress
Copy link

cypress bot commented Aug 25, 2023

15 failed tests on run #542 ↗︎

15 10 0 0 Flakiness 0

Details:

feat: add config option mobile_editing
Project: Richdocuments Commit: 03e2c5b5b9
Status: Failed Duration: 03:04 💡
Started: Aug 25, 2023 7:22 PM Ended: Aug 25, 2023 7:25 PM
Failed  open.spec.js • 8 failed tests

View Output Video

Test Artifacts
Open existing office files > Classic UI: Open document.odt the viewer on file click Output Screenshots
Open existing office files > Notebookbar UI: Open document.odt the viewer on file click Output Screenshots
Open existing office files > Classic UI: Open presentation.odp the viewer on file click Output Screenshots
Open existing office files > Notebookbar UI: Open presentation.odp the viewer on file click Output Screenshots
Open existing office files > Classic UI: Open spreadsheet.ods the viewer on file click Output Screenshots
Open existing office files > Notebookbar UI: Open spreadsheet.ods the viewer on file click Output Screenshots
Open existing office files > Classic UI: Open drawing.odg the viewer on file click Output Screenshots
Open existing office files > Notebookbar UI: Open drawing.odg the viewer on file click Output Screenshots
Failed  new.spec.js • 5 failed tests

View Output Video

Test Artifacts
Create new office files > Shows create file entries Output Screenshots
Create new office files > Create empty document file Output Screenshots
Create new office files > Create empty spreadsheet file Output Screenshots
Create new office files > Create empty presentation file Output Screenshots
Create new office files > Create empty diagram file Output Screenshots
Failed  share-internal.spec.js • 2 failed tests

View Output Video

Test Artifacts
File sharing of office documents > Open a shared file Output Screenshots
File sharing of office documents > Open a shared file as readonly Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliushaertl juliushaertl added enhancement New feature or request 3. to review Ready to be reviewed labels Aug 30, 2023
@juliushaertl juliushaertl merged commit 4f6adcf into main Aug 30, 2023
38 of 42 checks passed
@juliushaertl juliushaertl deleted the feature/add-config-option branch August 30, 2023 18:07
@luka-nextcloud
Copy link
Contributor Author

/backport to stable27

@luka-nextcloud
Copy link
Contributor Author

/backport to stable26

@luka-nextcloud
Copy link
Contributor Author

/backport to stable25

@luka-nextcloud
Copy link
Contributor Author

/backport to stable24

@luka-nextcloud
Copy link
Contributor Author

/backport to stable23

@luka-nextcloud
Copy link
Contributor Author

/backport to stable22

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable22
git pull origin stable22

# Create the new backport branch
git checkout -b fix/foo-stable22

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable22

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@juliushaertl juliushaertl mentioned this pull request Sep 1, 2023
7 tasks
@luka-nextcloud
Copy link
Contributor Author

/backport to stable4

@jakobroehrl
Copy link

@juliushaertl @luka-nextcloud
Good morning,
where can I configure this?
Some of my smartphones already can't open the mobile documents.
Could it be that it is disabled by default?
Thanks

@jakobroehrl
Copy link

@juliushaertl @luka-nextcloud
Tested a downgrade to 8.1.1. now it works again with the mobile apps.
So it must be this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants