-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix dropdowns have wrong mark color in browsers #3238
fix dropdowns have wrong mark color in browsers #3238
Conversation
aec36db
to
8aa58b3
Compare
CC: @juliushaertl can you please review this patch. |
@@ -88,8 +95,7 @@ const generateCSSVarTokens = () => { | |||
} | |||
|
|||
// New dark mode compatible way to hand over our Nextcloud variables in both light/dark to Collabora | |||
const lightElement = document.getElementById('cool-var-source-light') ?? document.documentElement | |||
const darkElement = document.getElementById('cool-var-source-dark') ?? document.documentElement | |||
const darkElement = createDataThemeDiv('div', 'dark') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also remove those elements after extracting the values again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nitpick to cleanup the elements, otherwise tested and works 👍
/backport to stable27 |
Also eslint is not happy:
|
8aa58b3
to
f67f25d
Compare
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
f67f25d
to
0791c56
Compare
CC: @juliushaertl |
Summary
cool-var-source-light
element is no longer loaded to office.vueTODO
Checklist