Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close NC sidebar on file open #3259

Conversation

Darshan-upadhyay1110
Copy link
Collaborator

Summary

- For internal shared links of Office documents sidebar gets open by default
- sidebar should not open at all when we click on document file or file gets opened by shared link

CC: @juliushaertl

@Darshan-upadhyay1110 Darshan-upadhyay1110 force-pushed the private/darshan/close-sidebar-on-file-open branch from 65cb0fd to 1930be4 Compare October 26, 2023 11:53
@Darshan-upadhyay1110
Copy link
Collaborator Author

@juliushaertl do we need backport to 27 and 26 as well ?

@juliushaertl
Copy link
Member

Yes, but we can do this likely automatically once this one is merged. No need to manually prepare those for now.

@juliushaertl
Copy link
Member

/backport to stable27

@juliushaertl
Copy link
Member

/backport to stable26

@juliushaertl
Copy link
Member

@Darshan-upadhyay1110 I also invited you to the repo so you can create branches directly here and CI will run automatically for future prs ;)

@Darshan-upadhyay1110
Copy link
Collaborator Author

@juliushaertl can we add comment in the main issue and do not close that ?

as this is a temp fix so it is good to just let that issue open for more generic fix

    - For internal shared links of Office documents sidebar gets open by default
    - sidebar should not open at all when we click on document file or file gets opened by shared link

Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
@juliushaertl juliushaertl force-pushed the private/darshan/close-sidebar-on-file-open branch from 1930be4 to e7b20af Compare October 27, 2023 08:17
@juliushaertl
Copy link
Member

@Darshan-upadhyay1110 When reviewing i figured out a better place to put this which actually resolves the flickering as well.

  • We close the sidebar now as early as the component renders
  • It is only closed when opening a normal file, not when you open a version viewer from the sidebar as in this case we want to keep the version listing open

@juliushaertl juliushaertl added bug Something isn't working 4. to release Ready to release, can be waiting for the tests to finish labels Oct 27, 2023
@juliushaertl juliushaertl merged commit 8d56643 into nextcloud:main Oct 30, 2023
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to release, can be waiting for the tests to finish bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Nextcloud sidebar shows up automatically and I don't understand its pattern
2 participants