fix: Emit warning instead of info when WOIP request is denied #3261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in nextcloud#2685 the message s quite important when tring to fix WOIP issues. The reasoning is that something fails from the perspective of an admin and it should emit a warning. Ofc. one could argue that the deny is expected bahaviour and should therefore emit only an info. Yet I believe that it'd be beneficial overall to consider admins that struggle to correctly set this up in that case. Signed-off-by: moanos <julian-samuel@gebuehr.net>
juliushaertl
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in #2685 the message s quite important when trying to fix WOIP issues. The reasoning is that something fails from the perspective of an admin and it should emit a warning.
Ofc. one could argue that the deny is expected behavior and should therefore emit only an info. Yet I believe that it'd be beneficial overall to consider admins that struggle to correctly set this up in that case.
TODO
Checklist