Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable27] Update files app state on saveAs #3276

Merged
merged 3 commits into from
Nov 7, 2023
Merged

[stable27] Update files app state on saveAs #3276

merged 3 commits into from
Nov 7, 2023

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Nov 6, 2023 •
edited
Loading

Combined backport of #3230 and #3277

@juliushaertl
fix: Update file metadata after save
574ef48 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl
fix: Sharing sidebar check for files app vue migration
e835299 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl changed the title Update files app state on saveAs [stable27] Update files app state on saveAs Nov 6, 2023
@juliushaertl juliushaertl marked this pull request as ready for review November 6, 2023 15:27
@juliushaertl juliushaertl added bug Something isn't working 3. to review Ready to be reviewed labels Nov 6, 2023
@cypress Cypress
Copy link

cypress bot commented Nov 6, 2023 •
edited
Loading

Passing run #706 ↗︎

0 31 0 0 Flakiness 0

Details:

[stable27] Update files app state on saveAs
Project: Richdocuments Commit: 88a36d7bfb
Status: Passed Duration: 03:09 💡
Started: Nov 7, 2023 7:50 AM Ended: Nov 7, 2023 7:54 AM

Review all test suite changes for PR #3276 ↗︎

@juliushaertl
fix: Properly update files app state when renaming/saveAs
88a36d7 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
mejo-
mejo- approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the changes comparing this and the parent PRs and looks sensible to me. Some changes from the parent PRs are not in this backport (namely changes to src/views/Office.vue), but they seem to have landed in stable27 before already.

@juliushaertl juliushaertl merged commit f3ec0de into stable27 Nov 7, 2023
36 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/stable27/saveas-update branch November 7, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejo- mejo- mejo- approved these changes

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud

Assignees
No one assigned
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliushaertl @mejo-