Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hide speadsheet statusbar by default #3324

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

pedropintosilva
Copy link
Contributor

Status bar is crucial for productivity tool (specially when it comes
to office suites and in specific spreadsheets).

Context, this is a regression from:

Even if, and as noted in
#2053 (comment),
the status bar was still being hidden for safari I think it's best to
don't break the spreadsheet experience for every browser. On top of
that I think the richdocuments frame suffer some changes and that
safari issue might not be present anymore.

Signed-off-by: Pedro Pinto Silva pedro.silva@collabora.com

  • Resolves: #
  • Target version: main

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

Status bar is crucial for productivity tool (specially when it comes
to office suites and in specific spreadsheets).

Context, this is a regression from:
- #2059
- fabed16

Even if,  and as noted in
#2053 (comment),
the status bar was still being hidden for safari I think it's best to
don't break the spreadsheet experience for every browser. On top of
that I think the richdocuments frame suffer some changes and that
safari issue might not be present anymore.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
@Darshan-upadhyay1110
Copy link
Collaborator

Tested working good. ByDefault statusbar is visible in spreadsheet

image

CC: @juliushaertl @pedropintosilva

@juliushaertl juliushaertl merged commit 9eea957 into main Nov 28, 2023
45 checks passed
@delete-merged-branch delete-merged-branch bot deleted the private/pedro/show-statusbar-spreadsheets branch November 28, 2023 06:58
@juliushaertl
Copy link
Member

/backport to stable27

@juliushaertl
Copy link
Member

/backport to stable26

@thebearon
Copy link
Collaborator

Status bar is crucial for productivity tool (specially when it comes to office suites and in specific spreadsheets).

Context, this is a regression from:

* [Revert "Do not hide speadsheet statusbar by default" #2059](https://github.com/nextcloud/richdocuments/pull/2059)

* [fabed16](https://github.com/nextcloud/richdocuments/commit/fabed162ea07ac27c031f288f0fab6f027badf78)

Even if, and as noted in #2053 (comment), the status bar was still being hidden for safari I think it's best to don't break the spreadsheet experience for every browser. On top of that I think the richdocuments frame suffer some changes and that safari issue might not be present anymore.

The showing of status bar and subsequent revert was done due to the opposite reason:
In Safari, the window height was shorter than it should've been due to a bug, and setting the status bar to show made it so at least the sheet list would be visible (but not the status bar still). Ie. showing the status bar temporarily set to true to avoid this problem in Safari, and then was reverted as the issue got fixed in COOL and the workaround was unneeded.
So, it wasn't a regression, but phasing out a temporary workaround.

@pedropintosilva Is there a reason not to enable the status bar in all apps by default? Only doing it for spreadsheets seems like an inconsistency to me.

@juliushaertl
Copy link
Member

This was mainly due to designers input to have a more simplified interface with Nextcloud office. cc @jancborchardt

@pedropintosilva
Copy link
Contributor Author

@pedropintosilva Is there a reason not to enable the status bar in all apps by default? Only doing it for spreadsheets seems like an inconsistency to me.

@thebearon : Juliu's comment is a direct answer to your question

@pedropintosilva
Copy link
Contributor Author

Nevertheless, I wonder if we should revisit that point. I just witness last week an user (German) being lost in Impress (presentations) when trying to zoom in. The user 1. went directly to the bottom right corner with the mouse pointer 2. Move the mouse pointer to the left still at the bottom 3. "There is no zoom option".

@juliushaertl
Copy link
Member

I think it makes sense to do some comparison here and pick what most users are used to on competitor (market leading) platforms. Zooming might for example also deserve a more prominent place. Or the status bar needs some revisiting to be less crowded (just from comparing with ms excel)

@thebearon
Copy link
Collaborator

@thebearon : Juliu's comment is a direct answer to your question

My question was about the inconsistency that it is now enabled in one app, but not in the others, while @juliushaertl 's answer was about why it had been disabled in all apps in the first place. My concern here is that the different defaults will lead to confusing UIs to unfamiliar users (like the one you mentioned, looking for the zoom option where the status bar would be, except now it will be there in Calc, but not in the other apps).

Nevertheless, I am glad to hear this is being revisited. Should we open a GH issue on it?

@juliushaertl
Copy link
Member

Filed as #3327 so we don't forget

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants