Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match dark theme of system if no nextcloud theme specified #3539

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

lpranam
Copy link
Contributor

@lpranam lpranam commented Mar 21, 2024

problem example:
a new user is created who uses system dark mode, so nextcloud will be in dark mode but collabora would not be turned to dark mode as all the themes(ie:themeDark and themeDarkHighcontrast) value are undefined

  • Target version: main

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@juliushaertl juliushaertl added bug Something isn't working 2. developing Work in progress labels Mar 26, 2024
problem example:
a new user is created who uses system dark mode, so nextcloud will be in dark mode
but collabora would not be turned to dark mode as all the themes(ie:themeDark and themeDarkHighcontrast) value are undefined

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
@juliushaertl
Copy link
Member

Thanks a lot @lpranam

There is indeed some inconsistency between the default for a new user or when manually setting the default, I adapted your change a bit to also properly work with public share links and to take the change from https://github.com/nextcloud/richdocuments/pull/3445/files into account

@juliushaertl
Copy link
Member

/backport to stable28

@juliushaertl
Copy link
Member

/backport to stable27

@juliushaertl juliushaertl merged commit d4a6b85 into nextcloud:main Mar 27, 2024
45 checks passed
@lpranam lpranam deleted the dark_theme_error branch March 27, 2024 09:07
@Ornanovitch
Copy link

Ornanovitch commented Mar 27, 2024

Interesting, thanks for this enhancement :)

However, while there is no doubt this will be great in the near future, Collabora still has a lot of problems with its "full dark" mode and a lot of NC users might complain soon. How could an admin "force" the light mode on in the meantime?

cc @juliushaertl @lpranam

@HolgerHees
Copy link

also after the latest fix, the error still happens. I'm running latest richdocument app (8.3.4)

I have embedded nextcloud inside an iframe like

outer frame is mydomain.de
nextcloud frame is nextcloud.mydomain.de

and I get the error "DOMException: Permission denied to access property "document" on cross-origin object"

I thin you should catch this kind of errors and just ignore, because it is not allowed to access the outer frame

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants