-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
match dark theme of system if no nextcloud theme specified #3539
Conversation
problem example: a new user is created who uses system dark mode, so nextcloud will be in dark mode but collabora would not be turned to dark mode as all the themes(ie:themeDark and themeDarkHighcontrast) value are undefined Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
b77ba6f
to
5826ae4
Compare
Thanks a lot @lpranam There is indeed some inconsistency between the default for a new user or when manually setting the default, I adapted your change a bit to also properly work with public share links and to take the change from https://github.com/nextcloud/richdocuments/pull/3445/files into account |
/backport to stable28 |
/backport to stable27 |
Interesting, thanks for this enhancement :) However, while there is no doubt this will be great in the near future, Collabora still has a lot of problems with its "full dark" mode and a lot of NC users might complain soon. How could an admin "force" the light mode on in the meantime? |
also after the latest fix, the error still happens. I'm running latest richdocument app (8.3.4) I have embedded nextcloud inside an iframe like outer frame is mydomain.de and I get the error "DOMException: Permission denied to access property "document" on cross-origin object" I thin you should catch this kind of errors and just ignore, because it is not allowed to access the outer frame |
problem example:
a new user is created who uses system dark mode, so nextcloud will be in dark mode but collabora would not be turned to dark mode as all the themes(ie:themeDark and themeDarkHighcontrast) value are undefined
Checklist