[stable26] fix: Use Close_Session post message to properly end the Collabora editing before opening locally #3597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliushaertl
changed the title
Passing run #826 ↗︎
Details:
Review all test suite changes for PR #3597 ↗︎ |
|||||||||||||||
juliushaertl
force-pushed
the
fix/local-locking-stable26
branch
from
b3e874e
to
0bc3072
Compare
max-nextcloud
approved these changes
Apr 16, 2024
…ting before opening locally Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
fix/local-locking-stable26
branch
from
0bc3072
to
2b2bbfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stable26 variant of #3601
If we edit locally we want to ensure that the document is saved and all sessions are removed before handing over the file to the desktop client. The previous approach was somewhat flaky and could lead to opening the file locally too early. The Close_Session post message will ensure that the file is properly terminated on the Collabora side and the lock on it is removed.
Further we can use the Session_Closed post message on other editing sessions to show a hint to the user why the document was auto-closed.