-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File action to open PDFs with richdocuments when files_pdfviewer is enabled #3645
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment on the app icon, otherwise very nice and good to get in 👍
6ff449a
to
a75c2c8
Compare
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
a75c2c8
to
43a8263
Compare
/backport to stable29 |
/backport to stable28 |
@elzody Would be quite nice if we could follow up with a small cypress test for this to avoid further regressions |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Summary
Since 28, when the files_pdfviewer app is enabled, there is no open to open a PDF using richdocuments. This PR fixes that, using the files API to register a file action. By default, when you click on the file, it will still use the files_pdfviewer when enabled.
Checklist