Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SPDX header #3664

Merged
merged 11 commits into from
May 13, 2024
Merged

Add SPDX header #3664

merged 11 commits into from
May 13, 2024

Conversation

AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented May 6, 2024 •
edited
Loading

  • Resolves: none
  • Target version: main

Summary

TODO

  • finish-up adding missing header
  • run spdx converter
  • add reuse GH action

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@AndyScherzinger AndyScherzinger force-pushed the chore/noid/spdx branch 3 times, most recently from ba1620f to d7d7f49 Compare May 6, 2024 12:17
@AndyScherzinger AndyScherzinger added 3. to review Ready to be reviewed and removed 2. developing Work in progress labels May 6, 2024
@AndyScherzinger AndyScherzinger marked this pull request as ready for review May 6, 2024 12:28
@AndyScherzinger
Copy link
Member Author

Auto loader check fails: would need help to understand why and how to fix.
https://github.com/nextcloud/richdocuments/actions/runs/8968932531/job/24629343575?pr=3664

juliushaertl
juliushaertl reviewed May 6, 2024
View reviewed changes
composer/autoload.php Outdated Show resolved Hide resolved
@AndyScherzinger AndyScherzinger force-pushed the chore/noid/spdx branch 3 times, most recently from 3c7ee78 to d19e3aa Compare May 8, 2024 15:42
@juliushaertl juliushaertl force-pushed the chore/noid/spdx branch 4 times, most recently from 54ab2a0 to 631ff64 Compare May 8, 2024 21:26
AndyScherzinger and others added 9 commits May 9, 2024 10:37
@AndyScherzinger
chore: Add SPDX header
868859f 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
chore(ci): Add reuse check
f24c044 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
docs: Add reuse compliance badge
1734676 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
chore: Move generated files license info to dep5
b505e60 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
chore: Update reuse action
acbfa36 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@juliushaertl @AndyScherzinger
chore: Set copyright for generated composer file
2b57190 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@AndyScherzinger
fix: Add further SPDX headers
96e98e8 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix: Update actions from template repo
767b090 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix: add further SPDX headers
e9a4c15 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix: php lint
13edfd3 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@juliushaertl
Copy link
Member

Haven't seen this cypress failure before and main branch is passing, need to look into why that happens

@juliushaertl
fix: Make legacy template picker compatible with SPDX header comment
04e51a1 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl merged commit 41ff6c2 into main May 13, 2024
60 checks passed
@delete-merged-branch delete-merged-branch bot deleted the chore/noid/spdx branch May 13, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

Assignees
No one assigned
Labels
3. to review Ready to be reviewed technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndyScherzinger @juliushaertl